refactor: fix security hardcode, dead code, resource leaks, operator bugs

src/core/health.ts

@@ -6,28 +6,32 @@ import { logInfo, logWarn, logError } from '../utils';
 /**
  * HealthCheckMonitor: Periodically monitors the environment 
  * (Ollama, Disk, API) to ensure the agent stays functional.
+ * 
+ * Properly tracks the interval timer for cleanup on deactivation.
  */
 export class HealthCheckMonitor {
+    private static intervalHandle: ReturnType<typeof setInterval> | null = null;
+
     public static async runAllChecks(): Promise<{ ok: boolean; reports: string[] }> {
         const reports: string[] = [];
         const config = getConfig();
 
-        // 1. Ollama Connectivity Check
+        // 1. AI Engine Connectivity Check
         try {
             const res = await fetch(`${config.ollamaUrl}/api/tags`, { signal: AbortSignal.timeout(3000) });
             if (res.ok) {
-                logInfo('Health Check: Ollama connectivity OK.');
+                logInfo('Health Check: AI engine connectivity OK.');
             } else {
-                reports.push('⚠️ AI Server (Ollama) is reachable but returned an error.');
+                reports.push('AI Server is reachable but returned an error.');
             }
         } catch {
-            reports.push('❌ AI Server (Ollama) is NOT reachable. Please check if it is running.');
+            reports.push('AI Server is NOT reachable. Please check if it is running.');
         }
 
         // 2. Workspace Validation
         const workspaceFolders = vscode.workspace.workspaceFolders;
         if (!workspaceFolders || workspaceFolders.length === 0) {
-            reports.push('⚠️ No workspace folder open. Agent capabilities will be limited.');
+            reports.push('No workspace folder open. Agent capabilities will be limited.');
         }
 
         // 3. Simple Disk/Permissions Check
@@ -39,7 +43,7 @@ export class HealthCheckMonitor {
                 logInfo('Health Check: Write permissions OK.');
             }
         } catch {
-            reports.push('❌ Write permissions denied in the current workspace.');
+            reports.push('Write permissions denied in the current workspace.');
         }
 
         if (reports.length > 0) {
@@ -53,7 +57,23 @@ export class HealthCheckMonitor {
         };
     }
 
-    public static startInterval(ms: number = 300000) { // Default 5 mins
-        setInterval(() => this.runAllChecks(), ms);
+    public static startInterval(ms: number = 300000) {
+        // Prevent duplicate intervals
+        if (this.intervalHandle !== null) {
+            clearInterval(this.intervalHandle);
+        }
+        this.intervalHandle = setInterval(() => this.runAllChecks(), ms);
+    }
+
+    /**
+     * Stops periodic health checks and releases resources.
+     * Should be called from extension.deactivate().
+     */
+    public static dispose(): void {
+        if (this.intervalHandle !== null) {
+            clearInterval(this.intervalHandle);
+            this.intervalHandle = null;
+            logInfo('Health Check: Interval stopped.');
+        }
     }
 }